Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Truncated Normal and Wald Distributions to V4 #4711

Merged
merged 12 commits into from
Jul 2, 2021
Merged

Port Truncated Normal and Wald Distributions to V4 #4711

merged 12 commits into from
Jul 2, 2021

Commits on Jul 2, 2021

  1. Refactor Truncated Normal

    @matteo-pallini @michaelosthege
    matteo-pallini authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    b8c2a95 View commit details
    Browse the repository at this point in the history

  2. Fix failing test case

    @ricardoV94 @michaelosthege
    ricardoV94 authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    b265c93 View commit details
    Browse the repository at this point in the history

  3. Address review feedback 

    - remove upper and lower checks and check for lack of bounds in logp and
  intervals directly
- pass default value for dist as `testval` to Distribution dist method
    @matteo-pallini @michaelosthege
    matteo-pallini authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8dfa4ed View commit details
    Browse the repository at this point in the history

  4. Refactor Wald distribution

    @matteo-pallini @michaelosthege
    matteo-pallini authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    621ffed View commit details
    Browse the repository at this point in the history

  5. Add logp and transform tests for truncated normal

    @matteo-pallini @michaelosthege
    matteo-pallini authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8c953be View commit details
    Browse the repository at this point in the history

  6. Move Wald distribution to use the numpy rvs implementation

    @matteo-pallini @michaelosthege
    matteo-pallini authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    09ddeca View commit details
    Browse the repository at this point in the history

  7. Simplify None bound replacement

    @ricardoV94 @michaelosthege
    ricardoV94 authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    7d80beb View commit details
    Browse the repository at this point in the history

  8. Make TestBoundedContinuous more readable

    @ricardoV94 @michaelosthege
    ricardoV94 authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    acf0caa View commit details
    Browse the repository at this point in the history

  9. Add arrays test for Wald, remove useless test and simplify sampling f… 

    …rom numpy wald
    @matteo-pallini @michaelosthege
    matteo-pallini authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    e72d9d5 View commit details
    Browse the repository at this point in the history

  10. Remove redundant tests

    @ricardoV94 @michaelosthege
    ricardoV94 authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    c89826e View commit details
    Browse the repository at this point in the history

  11. remove unnecessary variable assignment

    @matteo-pallini @michaelosthege
    matteo-pallini authored and michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    4449ef6 View commit details
    Browse the repository at this point in the history

  12. Remove xfail mark on TrucatedNormal tests

    @michaelosthege
    michaelosthege committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    58b6158 View commit details
    Browse the repository at this point in the history