Return InferenceData by default #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
commented
Jun 6, 2021
| trace = pm.sample(100, cores=1) | ||
|
|
||
| samples = 500 | ||
| size = 100 |
There was a problem hiding this comment.
This test looks suspiciously like some asserts were accidentally deleted at some point in the past.
This is why I prefer to put a pass at the end of tests!
michaelosthege
force-pushed
the
inferencedata-by-default
branch
from
d6e98da to
ca3c236
Compare
OriolAbril
reviewed
Jun 6, 2021
michaelosthege
force-pushed
the
inferencedata-by-default
branch
from
ca3c236 to
e0d261d
Compare
Also removes some unnecessary XFAIL marks. Closes pymc-devs#4372, pymc-devs#4740 Co-authored-by: Oriol Abril <oriol.abril.pla@gmail.com>
michaelosthege
force-pushed
the
inferencedata-by-default
branch
from
e0d261d to
a584af1
Compare
twiecki
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes some unnecessary XFAIL marks.
In multiple places I edited code examples in docstrings/documentation, as well as variable names in the tests to reflect that the returned object is no longer a
MultiTrace, but anInferenceDatainstead.Closes #4372, #4740
what are the (breaking) changes that this PR makes?pm.samplenow returnsInferenceDataby default. This was prominently announced since at least version3.11.0.important background, or details about the implementationSome tests remain withreturn_inferencedata=False, because they test internal logic that is relevant before the conversion. Some more tests remain withreturn_inferencedata=Falsebecause I was too lazy to migrate them all.are the changes—especially new features—covered by tests and docstrings?Countless times.linting/style checks have been runconsider adding/updating relevant example notebooksMany useInferenceDataalready.right before it's ready to merge, mention the PR in the RELEASE-NOTES.mddone