Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move content of distributions.special into distributions.dist_math #4760

Merged
merged 12 commits into from
Jun 10, 2021
Merged

Move content of distributions.special into distributions.dist_math #4760

merged 12 commits into from
Jun 10, 2021

Conversation

themrzmaster
Copy link
Contributor

@themrzmaster themrzmaster commented Jun 9, 2021 •
edited
Loading

@ricardoV94
Copy link
Member

ricardoV94 commented Jun 9, 2021 •
edited
Loading

The failing tests seem to be unrelated:

I am coming back to fix it in this PR #4736

ricardoV94
ricardoV94 reviewed Jun 10, 2021
View reviewed changes
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of minor comments. Let me know if you agree. Otherwise looks fine :)

@themrzmaster themrzmaster requested a review from ricardoV94 June 10, 2021 14:18
ricardoV94
ricardoV94 approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

michaelosthege
michaelosthege approved these changes Jun 10, 2021
View reviewed changes
pymc3/tests/test_distributions.py
@@ -1356,13 +1356,16 @@ def test_t(self):
lambda value, nu, mu, lam: sp.t.logcdf(value, nu, mu, lam ** -0.5),
n_samples=10, # relies on slow incomplete beta
)
# TODO: reenable when PR #4736 is merged
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reminder issue would be good. Or @ricardoV94 you rebase the other PR after we merge it and then you can enable it right there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that. Linking it here for now #4736

pymc3/tests/test_dist_math.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 merged commit 75c2e1e into pymc-devs:main Jun 10, 2021
@ricardoV94
Copy link
Member

Thanks @themrzmaster!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 approved these changes

@michaelosthege michaelosthege michaelosthege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move content of distributions.special into distributions.dist_math
3 participants
@themrzmaster @ricardoV94 @michaelosthege