Refactor ModelGraph for v4 #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
approved these changes
Jun 29, 2021
The issue exists with #4494 and there was a PR #4692 that went stale because of architectural considerations 🙁 For the record: I considered the |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4816
Thank your for opening a PR!
Depending on what your PR does, here are a few things you might want to address in the description:
what are the (breaking) changes that this PR makes?Noneimportant background, or details about the implementationdoes not applyare the changes—especially new features—covered by tests and docstrings?yuplinting/style checks have been runyupconsider adding/updating relevant example notebooksright before it's ready to merge, mention the PR in the RELEASE-NOTES.mdNot relevant, because it's just preventing API breakage.