Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no print statements #4878

Merged
merged 1 commit into from
Jul 26, 2021
Merged

no print statements #4878

merged 1 commit into from
Jul 26, 2021

Conversation

MarcoGorelli
Copy link
Contributor

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

cc @ricardoV94 @canyon289

@MarcoGorelli MarcoGorelli marked this pull request as draft July 25, 2021 14:01
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #4878 (8003e56) into main (bc2c24a) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4878      +/-   ##
==========================================
- Coverage   72.81%   72.81%   -0.01%     
==========================================
  Files          86       86              
  Lines       13795    13797       +2     
==========================================
+ Hits        10045    10046       +1     
- Misses       3750     3751       +1     
Impacted Files Coverage Δ
pymc3/math.py 67.85% <0.00%> (ø)
pymc3/sampling_jax.py 0.00% <0.00%> (ø)
pymc3/tuning/starting.py 83.19% <100.00%> (+0.14%) ⬆️

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 25, 2021 14:37
Copy link
Contributor

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is this PR trying to accomplish? Why do changes like this warrant an entire custom pre-commit plugin?

@MarcoGorelli
Copy link
Contributor Author

it was suggested/requested here , then discussion started again on Slack after arviz-devs/arviz#1560

@twiecki twiecki merged commit cdc6a39 into pymc-devs:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants