-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding StickBreakingWeights
distribution class
#5200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two sets of tests not passing locally in test_distributions.py
and test_distributions_moments.py
. The test in test_distributions_random.py
seems okay (from my perspective)
Codecov Report
@@ Coverage Diff @@
## main #5200 +/- ##
==========================================
+ Coverage 80.36% 80.38% +0.01%
==========================================
Files 89 89
Lines 14808 14867 +59
==========================================
+ Hits 11901 11951 +50
- Misses 2907 2916 +9
|
ec83b95
to
8109c6f
Compare
1fb33c7
to
028d77a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about test_distributions.py
028d77a
to
c47af07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Left some comments bellow, mostly concerning tests. Glad to see this PR entering the polishing phase!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
December 20 work in progress
c47af07
to
86be0d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two new sets of tests + question in make_node
9657f2d
to
6b5f5af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left some comments, let me know if anything is confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awesome work @larryshamalama
As always, thanks so much for all your suggestions and help @ricardoV94 |
Would be great to have an example NB in pymc-examples that shows how to use this. |
This pull request adds a class for truncated stick-breaking weights which are vital in the construction of Dirichlet Processes, which I hope to work on soon. See section 1.1 in Ishwaran and James (2001). My previous attempt as a PR is #4971 .
Some tests are failing, will have to resolve them first.
CC: @ricardoV94 @AustinRochford @fonnesbeck