Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Sequential Monte Carlo internals #5281

Merged
merged 3 commits into from
Dec 24, 2021

Conversation

ciguaran
Copy link
Contributor

This is my first PR ever to Pymc.
There should not be any breaking changes. This PR modularizes a little bit SMC internals.
This is an initial refactor, that adds documentation and makes it easier for a new reader to find where the actual SMC sampling happens, vs what checks/stats are generated.
@ricardoV94

pymc/tests/test_smc.py Outdated Show resolved Hide resolved
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #5281 (72834d5) into main (9d4691c) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5281      +/-   ##
==========================================
+ Coverage   78.98%   78.99%   +0.01%     
==========================================
  Files          88       87       -1     
  Lines       14273    14364      +91     
==========================================
+ Hits        11273    11347      +74     
- Misses       3000     3017      +17     
Impacted Files Coverage Δ
pymc/smc/smc.py 97.89% <50.00%> (-0.41%) ⬇️
pymc/smc/sample_smc.py 83.22% <67.56%> (-0.12%) ⬇️
pymc/backends/ndarray.py 79.64% <0.00%> (-9.74%) ⬇️
pymc/bart/utils.py 82.60% <0.00%> (-5.92%) ⬇️
pymc/backends/report.py 89.51% <0.00%> (-2.10%) ⬇️
pymc/distributions/dist_math.py 86.78% <0.00%> (-0.92%) ⬇️
pymc/sampling.py 86.23% <0.00%> (-0.57%) ⬇️
pymc/backends/arviz.py 89.12% <0.00%> (-0.44%) ⬇️
pymc/gp/gp.py 93.18% <0.00%> (-0.43%) ⬇️
pymc/model.py 82.99% <0.00%> (-0.32%) ⬇️
... and 18 more

@ricardoV94 ricardoV94 merged commit e6fc2ec into pymc-devs:main Dec 24, 2021
@ricardoV94
Copy link
Member

Thanks @ciguaran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants