Workaround for #5310: theano import error with recent NumPy #5316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
previously approved these changes
Jan 6, 2022
|
@treszkai did you tick the "allow maintainers to push this branch" checkbox? I tried to commit a mention in the release notes using the GitHub Web IDE, but it won't let me do it. Otherwise please append this to the "3.11.5" section in the release notes, and remove that one line 29 in the ### Bugfixes
+ A hotfix is applied on import to remain compatible with NumPy 1.22 (see [#5316](https://github.com/pymc-devs/pymc/pull/5316)).
|
|
@michaelosthege I only clicked "Allow edits by maintainers" in this PR. Edited the release notes and removed the Aesara comment. |
michaelosthege
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing Theano with NumPy>=1.22.0 installed raises an exception as it accesses an undefined variable in NumPy's
__config__module. This PR implements a workaround as suggested in #5310 (comment)