Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test conditional workflow runs #5364

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Test conditional workflow runs #5364

merged 4 commits into from
Jan 20, 2022

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jan 17, 2022

Also use the opportunity for some cleanup of infrastructure related files

@OriolAbril
Copy link
Member Author

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #5364 (40f8683) into main (d52655d) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5364      +/-   ##
==========================================
+ Coverage   80.36%   80.40%   +0.03%     
==========================================
  Files          89       82       -7     
  Lines       14808    14067     -741     
==========================================
- Hits        11901    11311     -590     
+ Misses       2907     2756     -151     
Impacted Files Coverage Δ
pymc/tests/backend_fixtures.py
pymc/tests/__init__.py
pymc/tests/helpers.py
pymc/tests/conftest.py
pymc/tests/checks.py
pymc/tests/models.py
pymc/tests/sampler_fixtures.py

@OriolAbril
Copy link
Member Author

If someone can look into the actions thing that would be great, otherwise I'll remove those files from the PR and keep only the removals of unused files

@michaelosthege
Copy link
Member

For the CI runs here, your changes did not have an effect. Maybe because it need to have been merged first?

@OriolAbril
Copy link
Member Author

Let's try if merging works, good idea

@OriolAbril OriolAbril merged commit d6b8107 into main Jan 20, 2022
@OriolAbril OriolAbril deleted the cleanup branch January 20, 2022 01:11
michaelosthege added a commit that referenced this pull request Mar 18, 2022
Previously there were two trigger conditions (PRs and pushes to main).
With the change all pushes (to PR branches or main) trigger it,
and the `paths:` filter applies every time.

This is a follow-up to #5364.
michaelosthege added a commit that referenced this pull request Mar 18, 2022
Previously there were two trigger conditions (PRs and pushes to main).
With the change all pushes (to PR branches or main) trigger it,
and the `paths:` filter applies every time.

This is a follow-up to #5364.
michaelosthege added a commit that referenced this pull request Mar 19, 2022
Previously only one of the trigger conditions had the filter.
This is a follow-up to #5364.
michaelosthege added a commit that referenced this pull request Mar 19, 2022
Previously only one of the trigger conditions had the filter.
This is a follow-up to #5364.
michaelosthege added a commit that referenced this pull request Mar 19, 2022
Previously only one of the trigger conditions had the filter.
This is a follow-up to #5364.
michaelosthege added a commit that referenced this pull request Mar 19, 2022
Previously only one of the trigger conditions had the filter.
This is a follow-up to #5364.

Fixup
michaelosthege added a commit to michaelosthege/pymc that referenced this pull request Mar 19, 2022
Previously only one of the trigger conditions had the filter.

This is a follow-up to pymc-devs#5364.
michaelosthege added a commit that referenced this pull request Mar 19, 2022
Previously only one of the trigger conditions had the filter.

This is a follow-up to #5364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants