Do not set RNG updates inplace in compile_pymc #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5615 +/- ##
==========================================
+ Coverage 87.68% 87.69% +0.01%
==========================================
Files 76 76
Lines 13702 13717 +15
==========================================
+ Hits 12014 12029 +15
Misses 1688 1688
|
ricardoV94
force-pushed
the
compile_pymc_non_inplace
branch
from
8ee67a5 to
4f13b2c
Compare
michaelosthege
approved these changes
Mar 18, 2022
|
Yeah it's the one in #5575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small maintenance change. No point in doing changes inplace if we don't have to