Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StudentT/AsymmetricLaplace .dist() signatures consistent #5628

Merged
merged 22 commits into from
Apr 15, 2022
Merged

Make StudentT/AsymmetricLaplace .dist() signatures consistent #5628

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
fcee3b6
Revised community naming/mission
cluhmann Feb 9, 2022
69001cd
make dist signatures consistent
cluhmann Mar 20, 2022
c477181
revert unrelated changes
cluhmann Mar 20, 2022
1bc3661
update signatures of half/studentT
cluhmann Mar 21, 2022
61def77
fix args
cluhmann Mar 21, 2022
f9ac4f0
update release notes
cluhmann Mar 21, 2022
3fb2844
update docstring and release notes
cluhmann Mar 21, 2022
6b9490c
update halfstudentt test and release notes
cluhmann Mar 22, 2022
5e19a0d
Merge branch 'main' into distsigs
cluhmann Mar 22, 2022
05e6130
Revised community naming/mission
cluhmann Feb 9, 2022
4076386
make dist signatures consistent
cluhmann Mar 20, 2022
9b50644
revert unrelated changes
cluhmann Mar 20, 2022
731026c
update signatures of half/studentT
cluhmann Mar 21, 2022
520646b
fix args
cluhmann Mar 21, 2022
9c5d531
update release notes
cluhmann Mar 21, 2022
c3c3942
update docstring and release notes
cluhmann Mar 21, 2022
d7facdc
update halfstudentt test and release notes
cluhmann Mar 22, 2022
095dab7
fix borked merge
cluhmann Mar 22, 2022
ea65542
update AsymmetricLaplace doc string
cluhmann Mar 23, 2022
705aff1
Merge branch 'pymc-devs:main' into distsigs
cluhmann Mar 29, 2022
b83e0bb
tidy up release notes
cluhmann Mar 29, 2022
f33fc00
Merge branch 'distsigs' of https://github.com/cluhmann/pymc into dist…
cluhmann Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,3 +833,4 @@ extra benefits but those will be related to the conference, not the Project.
* Sharan Yalburgi (GSoC 2018)
* Taku Yoshioka
* Tirth Patel (GSoC 2020)

4 changes: 2 additions & 2 deletions pymc/distributions/continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1662,7 +1662,7 @@ class AsymmetricLaplace(Continuous):
rv_op = asymmetriclaplace

@classmethod
def dist(cls, b, kappa, mu=0, *args, **kwargs):
def dist(cls, kappa, mu, b, *args, **kwargs):
b = at.as_tensor_variable(floatX(b))
kappa = at.as_tensor_variable(floatX(kappa))
mu = mu = at.as_tensor_variable(floatX(mu))
Expand Down Expand Up @@ -1901,7 +1901,7 @@ class StudentT(Continuous):
rv_op = studentt

@classmethod
def dist(cls, nu, mu=0, lam=None, sigma=None, *args, **kwargs):
def dist(cls, nu=1, mu=0, sigma=None, lam=None, *args, **kwargs):
nu = at.as_tensor_variable(floatX(nu))
lam, sigma = get_tau_sigma(tau=lam, sigma=sigma)
sigma = at.as_tensor_variable(sigma)
Expand Down