Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally depend on pandas in tests #5633

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

thomasjpfan
Copy link
Contributor

Closes #5469

This PR updates the tests to conditionally dependent on pandas. With this PR the only code that uses pandas are maintenance, benchmark scripts, and two notebooks:

  • scripts/check_all_tests_are_covered.py
  • scripts/run_mypy.py
  • benchmarks/benchmarks/benchmarks.py
  • docs/source/learn/examples/GLM_linear.ipynb
  • docs/source/learn/examples/pymc_overview.ipynb

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #5633 (7e19704) into main (b895e40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5633   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files          76       76           
  Lines       13717    13717           
=======================================
  Hits        12021    12021           
  Misses       1696     1696           

@michaelosthege
Copy link
Member

Do you want to remove pandas from the requirements.txt then?
Since it's only used in the tests, maybe that would have been enough. But the changes look good - just one file where you forgot this importskip thing

@ricardoV94
Copy link
Member

@thomasjpfan May I ask what does CLN in your PR title stand for?

@thomasjpfan thomasjpfan changed the title CLN Conditionally depend on pandas in tests Conditionally depend on pandas in tests Mar 22, 2022
@thomasjpfan
Copy link
Contributor Author

May I ask what does CLN in your PR title stand for?

It means "Clean". I like to tag my commits so they are easier to track down in the future.

That being said, I removed it from the PR title.

@michaelosthege michaelosthege merged commit 9c2ba7a into pymc-devs:main Mar 25, 2022
@michaelosthege
Copy link
Member

Thanks, @thomasjpfan !

Lets hope this makes the life of conda/mamba dependency resolves a little less complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Pandas dependency
3 participants