Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all cache actions to v3 #5647

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Mar 24, 2022

According to their release notes, there were performance improvements and security fixes in v2.

The v3 bump had a breaking change for users of (outdated) custom runners which does not apply to us.

Notice that in the CI run of this PR the caching did not work - most probably because of the update.
But in the last run on main it worked for all three OSes.

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #5647 (2748699) into main (d322b81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5647   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files          75       75           
  Lines       13677    13677           
=======================================
  Hits        12114    12114           
  Misses       1563     1563           

@michaelosthege michaelosthege marked this pull request as ready for review March 24, 2022 11:41
@michaelosthege michaelosthege merged commit e4a07c1 into pymc-devs:main Mar 24, 2022
@michaelosthege michaelosthege deleted the update-cache-action branch March 24, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants