Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aesara dependency #5757

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

ricardoV94
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #5757 (42e3745) into main (42e3745) will not change coverage.
The diff coverage is n/a.

❗ Current head 42e3745 differs from pull request most recent head ebdc1e1. Consider uploading reports for the commit ebdc1e1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5757   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files          74       74           
  Lines       13811    13811           
=======================================
  Hits        12286    12286           
  Misses       1525     1525           

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳 it

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, wait. That failing test looks like a new bug?

@ricardoV94
Copy link
Member Author

ricardoV94 commented May 11, 2022

Aesara issue opened: aesara-devs/aesara#955

@twiecki
Copy link
Member

twiecki commented Jun 1, 2022

Can we xfail or is this critical?

@michaelosthege
Copy link
Member

Looks like some kind of tensor typing problem:
https://github.com/pymc-devs/pymc/runs/6374288465?check_suite_focus=true#step:7:1429

TypeError: The type of the replacement (TensorType(float64, (1, None))) must be compatible with the type of the original Variable (TensorType(float64, (1, 20))).

@ricardoV94
Copy link
Member Author

No need to guess guys, there's a linked issue: aesara-devs/aesara#955

@ricardoV94
Copy link
Member Author

This should only show up as a warning under normal aesara flags, and only in some edge cases. It will be fixed in a future release but for now I think it's fine to temporarily xfail

@ricardoV94 ricardoV94 added this to the v4.0.0 milestone Jun 2, 2022
@ricardoV94
Copy link
Member Author

ricardoV94 commented Jun 2, 2022

The test that is failing will be removed in #5806, it was not easy to turn it off due to the way it is parametrized.

In the meantime I rebased from main to see if anything else fails.

@twiecki
Copy link
Member

twiecki commented Jun 2, 2022

Seems still broken, or another test?

@ricardoV94
Copy link
Member Author

It's the same test, it will be removed in #5806, then we can rebase and it should be good to go.

@twiecki twiecki merged commit 559969c into pymc-devs:main Jun 2, 2022
@ricardoV94 ricardoV94 deleted the update_aesara_aeppl_deps branch June 6, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants