Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for converting code from 3 to 4. #5778

Closed
wants to merge 2 commits into from
Closed

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented May 17, 2022

Closes #4515

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #5778 (8c12b7c) into main (862bd05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5778   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          74       74           
  Lines       13813    13813           
=======================================
  Hits        12332    12332           
  Misses       1481     1481           

@ricardoV94
Copy link
Member

I don't like this :)

"s/PyMC3/PyMC/g"
"s/from theano import tensor as tt/import aesara.tensor as at/g"
"s/import theano\.tensor as tt/import aesara.tensor as at/g"
"s/tt\./at./g"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very dangerous. It will replace any tt. with at., regardless of where in the line, tt is found. It should somehow have a lookbehind that checks if tt was not preceded by a letter, underscore or a dot. From the little I know of sed, I think that it doesn't support look around conditions (see here)

@twiecki
Copy link
Member Author

twiecki commented May 18, 2022

Alright then :).

@twiecki twiecki closed this May 18, 2022
@canyon289
Copy link
Member

@ricardoV94 just curious, do you not like this because its a bash script, or dont like the idea of an autoconverter?

@ricardoV94
Copy link
Member

@ricardoV94 just curious, do you not like this because its a bash script, or dont like the idea of an autoconverter?

The second

@ricardoV94 ricardoV94 deleted the pymc3_to_4_script branch November 2, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write v4 upgrade guide
4 participants