fix Model docstring #6048
fix Model docstring #6048
Conversation
|
There are a few mentions of the I tried to commit to your branch to get this over the finish line, but somehow I couldn't. (At least not in GitHub.) @alekracicot can you insert the |
|
Yeah absolutely, I'll do that right now. |
|
@michaelosthege, I added the changes. |
|
Hi @alekracicot Or some other avenue? |
|
@reshamas No mostly the contributing section on the pymc website. |
Codecov Report
@@ Coverage Diff @@
## main #6048 +/- ##
==========================================
- Coverage 89.27% 89.05% -0.22%
==========================================
Files 72 72
Lines 12890 12924 +34
==========================================
+ Hits 11507 11510 +3
- Misses 1383 1414 +31
|
pymc/model.py
Outdated
| @@ -466,51 +466,50 @@ def __init__(self, mean=0, sigma=1, name=''): | |||
| # will get model's name prefix | |||
|
|
|||
| # 3) you can create variables with Var method | |||
There was a problem hiding this comment.
This still mentions var method
pymc/model.py
Outdated
| @@ -466,51 +466,50 @@ def __init__(self, mean=0, sigma=1, name=''): | |||
| # will get model's name prefix | |||
|
|
|||
| # 3) you can create variables with Var method | |||
| self.Var('v1', Normal.dist(mu=mean, sigma=sd)) | |||
| # this will create variable named like '{prefix::}v1' | |||
| self.register_rv(pm.Normal.dist(mu=mean, sigma=sigma), 'v1', initval=1) | |||
There was a problem hiding this comment.
| self.register_rv(pm.Normal.dist(mu=mean, sigma=sigma), 'v1', initval=1) | |
| self.register_rv(Normal.dist(mu=mean, sigma=sigma), 'v1', initval=1) |
Why are we adding the pm prefix and showing initval?
|
Ok, I will remove the pm. |
|
Thanks @alekracicot! |
What is this PR about?
...
Description: Change Model docstring
Issue name Model docstring is outdated
Closes #6040
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance