Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpecifyShape decorator to jax_funcify_Assert #6062

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

martiningram
Copy link
Contributor

@martiningram martiningram commented Aug 25, 2022

What is this PR about?
This PR addresses the problem raised in #6050 and implements the fix suggested by @ricardoV94 . It consists of only two lines, so it is not a major change.

Closes #6050

Major / Breaking Changes

  • ...

Bugfixes / New features

Docs / Maintenance

  • ...

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #6062 (c2cd53e) into main (093a734) will decrease coverage by 2.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6062      +/-   ##
==========================================
- Coverage   89.56%   87.46%   -2.10%     
==========================================
  Files          72       72              
  Lines       12941    12943       +2     
==========================================
- Hits        11591    11321     -270     
- Misses       1350     1622     +272     
Impacted Files Coverage Δ
pymc/sampling_jax.py 97.18% <100.00%> (+0.02%) ⬆️
pymc/distributions/timeseries.py 43.36% <0.00%> (-35.28%) ⬇️
pymc/model_graph.py 65.66% <0.00%> (-12.66%) ⬇️
pymc/model.py 76.14% <0.00%> (-12.06%) ⬇️
pymc/step_methods/hmc/quadpotential.py 73.76% <0.00%> (-6.94%) ⬇️
pymc/util.py 75.29% <0.00%> (-2.36%) ⬇️
pymc/distributions/discrete.py 97.65% <0.00%> (-1.57%) ⬇️
pymc/distributions/multivariate.py 91.02% <0.00%> (-0.99%) ⬇️
pymc/printing.py 85.71% <0.00%> (-0.96%) ⬇️
pymc/step_methods/hmc/base_hmc.py 89.76% <0.00%> (-0.79%) ⬇️
... and 3 more

@ricardoV94
Copy link
Member

Pre-commit is complaining

@ricardoV94
Copy link
Member

ricardoV94 commented Aug 26, 2022

Same gp test failed in #6067

We should open an issue to investigate that as the flakiness seems recent. Opened an issue: #6069

@ricardoV94
Copy link
Member

We can merge with the failing test as it's unrelated, but @martiningram can you add the correct sections as in the PR guideline?

We need those for the release notes: https://github.com/pymc-devs/pymc/blob/main/.github/PULL_REQUEST_TEMPLATE.md

@martiningram
Copy link
Contributor Author

Hi @ricardoV94 , sorry for the sloppy PR, and thanks for your patience in getting it fixed up. I now edited the original PR message; does that look correct, or should I put the information somewhere else? Thanks!

@ricardoV94 ricardoV94 merged commit 5e7e389 into pymc-devs:main Aug 26, 2022
@ricardoV94
Copy link
Member

@martiningram no worries! Thank you for your contribution :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JAX-ified model throws error with SpecifyShape Op
2 participants