Rename cov_func/cov to scale_func/scale for TP/MvStudentT #6068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canyon289
reviewed
Aug 26, 2022
canyon289
approved these changes
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #6068 +/- ##
==========================================
+ Coverage 80.95% 89.54% +8.58%
==========================================
Files 72 72
Lines 12941 12950 +9
==========================================
+ Hits 10477 11596 +1119
+ Misses 2464 1354 -1110
|
ricardoV94
reviewed
Aug 26, 2022
pymc/distributions/multivariate.py
Outdated
| warnings.warn( | ||
| "Use the scale argument to specify the scale matrix." | ||
| "cov will be removed in future versions.", | ||
| DeprecationWarning, |
There was a problem hiding this comment.
I remember FutureWarning being the recommended one, but I am unsure.
Suggested change
| DeprecationWarning, | |
| FutureWarning, |
ricardoV94
approved these changes
Aug 26, 2022
bwengals
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scale matrix/function in the
MvStudentTdistribution and theTPhave to date been calledcovandcov_func, respectively. This is confusing because these are not covariance matrices/functions, but rather scale matrices/functions that only become covariances as a function of thenuparameter. This PR renamescovandcov_functoscaleandscale_func, respectively, but still allowscovandcov_funcfor backward compatibility, with a deprecation warning.Closes #2865
Checklist
Bugfixes / New features