Cleanup more warnings from the test suite #6074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NaNs are irrelevant because the other result is returned.
Codecov Report
@@ Coverage Diff @@
## main #6074 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 72 72
Lines 12950 12954 +4
=======================================
+ Hits 11593 11597 +4
Misses 1357 1357
|
michaelosthege
approved these changes
Aug 27, 2022
|
LGTM, thanks @Armavica ! |
|
This is incredible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR removes 459 warnings from the test suite, leaving only 19 remaining.
The remaining ones are warnings that I don't really understand yet, so I might leave them to somebody else, or come back to them in a while, when I am more familiar with the code base. They are generated by the following tests:
pymc/tests/test_distributions_moments.py::test_polyagamma_moment[1.0-0.0-None-0.25]pymc/tests/test_gp.py::TestCovKron::test_multiopspymc/tests/test_gp.py::TestCovKron::test_multiopspymc/tests/test_gp.py::TestCoregion::test_fullBpymc/tests/test_idata_conversion.py::TestDataPyMC::test_to_idatapymc/tests/test_idata_conversion.py::TestDataPyMC::test_no_tracepymc/tests/test_mixture.py::TestMixtureMoments::test_list_univariate_components[weights2-comp_dists2-size2-expected2]pymc/tests/test_mixture.py::TestMixtureMoments::test_list_multivariate_components[weights1-comp_dists1-size1-expected1]pymc/tests/test_mixture.py::TestMixtureMoments::test_list_multivariate_components[weights2-comp_dists2-None-expected2]pymc/tests/test_mixture.py::TestMixtureDefaultTransforms::test_expected[comp_dists4-NoneType]pymc/tests/test_mixture.py::TestMixtureDefaultTransforms::test_expected[comp_dists8-NoneType]pymc/tests/test_transforms.py::TestElementWiseLogp::test_triangular[lower2-c2-upper2-size2]pymc/tests/test_transforms.py::TestElementWiseLogp::test_triangular[lower2-c2-upper2-size2]pymc/tests/test_transforms.py::TestElementWiseLogp::test_uniform_other[0.5-5.5-size1-transform1]pymc/tests/test_transforms.py::TestElementWiseLogp::test_uniform_other[lower2-upper2-size2-transform2]pymc/tests/test_variational_inference.py::test_fit_oo[ADVI-mini]pymc/tests/test_variational_inference.py::test_fit_oo[FullRankADVI-mini]pymc/tests/test_variational_inference.py::test_fit_oo[SVGD-mini]pymc/tests/test_variational_inference.py::test_fit_oo[ASVGD-mini]Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance