Remove NoDistribution and enable .dist
API for Simulator and DensityDist
#6110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The NoDistribution was used originally for Simulator, to allow RVs in the graph, but that hasn't been needed for sometime.
Besides removing that class, this PR also implements the
.dist
API for DensityDist and Simulator so that they behave more like other Distributions. The only difference is that a class_name is required as these classes create new types dynamically.Closes #6031
Checklist
Major / Breaking Changes
Bugfixes / New features
.dist
APIDocs / Maintenance