-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for "dims on the fly" #6112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
remove_dims_on_fly
branch
from
September 9, 2022 15:03
844b5af
to
9113ad2
Compare
twiecki
approved these changes
Sep 9, 2022
Marking as a draft because some checks we had in |
ricardoV94
force-pushed
the
remove_dims_on_fly
branch
from
September 9, 2022 15:33
9113ad2
to
4a464bf
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6112 +/- ##
==========================================
- Coverage 91.37% 91.36% -0.01%
==========================================
Files 101 101
Lines 20887 20865 -22
==========================================
- Hits 19085 19064 -21
+ Misses 1802 1801 -1
|
ricardoV94
force-pushed
the
remove_dims_on_fly
branch
from
September 11, 2022 12:31
4a464bf
to
9d885ac
Compare
Failing test is unrelated: #6091 |
ricardoV94
commented
Sep 11, 2022
ricardoV94
force-pushed
the
remove_dims_on_fly
branch
from
September 14, 2022 14:47
9d885ac
to
53673a4
Compare
ricardoV94
force-pushed
the
remove_dims_on_fly
branch
from
September 14, 2022 14:51
53673a4
to
cc02373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6085
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance