Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for "dims on the fly" #6112

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Sep 9, 2022

Closes #6085

Checklist

Major / Breaking Changes

  • Dims can no longer be implied by the size of a variable or observed, they must always be defined in advance

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

@ricardoV94
Copy link
Member Author

Marking as a draft because some checks we had in model.set_data may no longer make sense?

@ricardoV94 ricardoV94 marked this pull request as draft September 9, 2022 15:33
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #6112 (cc02373) into main (c58ceb2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6112      +/-   ##
==========================================
- Coverage   91.37%   91.36%   -0.01%     
==========================================
  Files         101      101              
  Lines       20887    20865      -22     
==========================================
- Hits        19085    19064      -21     
+ Misses       1802     1801       -1     
Impacted Files Coverage Δ
pymc/distributions/distribution.py 94.03% <100.00%> (-0.19%) ⬇️
pymc/distributions/shape_utils.py 98.95% <100.00%> (+0.51%) ⬆️
pymc/tests/distributions/test_shape_utils.py 99.73% <100.00%> (-0.01%) ⬇️
pymc/distributions/timeseries.py 77.56% <0.00%> (-0.97%) ⬇️
pymc/parallel_sampling.py 86.79% <0.00%> (+0.99%) ⬆️

@michaelosthege michaelosthege added the major Include in major changes release notes section label Sep 9, 2022
@ricardoV94 ricardoV94 added this to the v4.2.0 milestone Sep 10, 2022
@ricardoV94
Copy link
Member Author

Failing test is unrelated: #6091

pymc/model.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 marked this pull request as ready for review September 14, 2022 14:58
@ricardoV94 ricardoV94 requested a review from twiecki September 14, 2022 15:04
@ricardoV94 ricardoV94 merged commit 2296350 into pymc-devs:main Sep 15, 2022
@ricardoV94 ricardoV94 deleted the remove_dims_on_fly branch June 6, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Include in major changes release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support of "dims on the fly"
3 participants