Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy dependency and instructions when test fails #6195

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Add mypy dependency and instructions when test fails #6195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da80895
Add mypy dependency to dev and test environments
ricardoV94 Oct 9, 2022
543c69b
Add instruction on how to run mypy test locally when it fails
ricardoV94 Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ jobs:
conda activate pymc-test
pip install -e .
pip install --pre -U polyagamma
pip install mypy types-cachetools
python --version
- name: Run mypy
run: |
Expand Down
2 changes: 2 additions & 0 deletions conda-envs/environment-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,5 @@ dependencies:
- watermark
- polyagamma
- sphinx-remove-toctrees
- mypy
- types-cachetools
2 changes: 2 additions & 0 deletions conda-envs/environment-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,5 @@ dependencies:
- pre-commit>=2.8.0
- pytest-cov>=2.5
- pytest>=3.0
- mypy
- types-cachetools
2 changes: 2 additions & 0 deletions conda-envs/windows-environment-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ dependencies:
- sphinx>=1.5
- watermark
- sphinx-remove-toctrees
- mypy
- types-cachetools
2 changes: 2 additions & 0 deletions conda-envs/windows-environment-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ dependencies:
- pre-commit>=2.8.0
- pytest-cov>=2.5
- pytest>=3.0
- mypy
- types-cachetools
2 changes: 2 additions & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ fastprogress>=0.2.0
h5py>=2.7
ipython>=7.16
jupyter-sphinx
mypy
myst-nb
numpy>=1.15.0
numpydoc
Expand All @@ -26,5 +27,6 @@ sphinx-notfound-page
sphinx-remove-toctrees
sphinx>=1.5
sphinxext-rediraffe
types-cachetools
typing-extensions>=3.7.4
watermark
2 changes: 1 addition & 1 deletion scripts/run_mypy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def check_no_unexpected_results(mypy_lines: Iterator[str]):
"These files did not fail before, so please check the above output"
f" for errors in {unexpected_failing} and fix them."
)
print("!!!!!!!!!")
print("You can run `python scripts/run_mypy.py --verbose` to reproduce this test locally.")
sys.exit(1)

if unexpected_passing == {"pymc/sampling_jax.py"}:
Expand Down