Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestMixture.test_component_choice_random #6222

Merged
merged 6 commits into from
Oct 21, 2022

Conversation

bherwerth
Copy link
Contributor

@bherwerth bherwerth commented Oct 17, 2022

What is this PR about?
Fixes #6210:

  • Use a seed for taking draws
  • Increase number of draws to 20

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • Fix flaky TestMixture.test_component_choice_random

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #6222 (514f765) into main (7503730) will decrease coverage by 18.74%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6222       +/-   ##
===========================================
- Coverage   93.61%   74.86%   -18.75%     
===========================================
  Files         101      101               
  Lines       22120    22129        +9     
===========================================
- Hits        20707    16567     -4140     
- Misses       1413     5562     +4149     
Impacted Files Coverage Δ
pymc/tests/distributions/test_mixture.py 99.35% <100.00%> (ø)
pymc/tests/step_methods/test_slicer.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/step_methods/hmc/test_nuts.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/step_methods/test_metropolis.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/distributions/test_continuous.py 0.00% <0.00%> (-99.77%) ⬇️
pymc/tests/distributions/test_multivariate.py 0.00% <0.00%> (-99.45%) ⬇️
pymc/tests/distributions/test_discrete.py 0.00% <0.00%> (-98.89%) ⬇️
pymc/tests/distributions/test_distribution.py 0.00% <0.00%> (-97.93%) ⬇️
pymc/tests/distributions/util.py 43.70% <0.00%> (-47.17%) ⬇️
pymc/distributions/multivariate.py 54.86% <0.00%> (-37.39%) ⬇️
... and 19 more

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I would rather keep the old check than the new one. What do you think?

pymc/tests/distributions/test_mixture.py Show resolved Hide resolved
bherwerth and others added 2 commits October 20, 2022 19:59
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
@ricardoV94 ricardoV94 marked this pull request as ready for review October 20, 2022 18:04
@ricardoV94 ricardoV94 changed the title Fix test component choice random Fix flaky test component choice random Oct 20, 2022
@ricardoV94 ricardoV94 changed the title Fix flaky test component choice random Fix flaky TestMixture.test_component_choice_random Oct 20, 2022
@ricardoV94 ricardoV94 merged commit a0f849a into pymc-devs:main Oct 21, 2022
@ricardoV94
Copy link
Member

Thanks @bherwerth!

@bherwerth bherwerth deleted the fix-test-component-choice-random branch October 22, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: test_component_choice_random
2 participants