-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky TestMixture.test_component_choice_random
#6222
Merged
ricardoV94
merged 6 commits into
pymc-devs:main
from
bherwerth:fix-test-component-choice-random
Oct 21, 2022
Merged
Fix flaky TestMixture.test_component_choice_random
#6222
ricardoV94
merged 6 commits into
pymc-devs:main
from
bherwerth:fix-test-component-choice-random
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6222 +/- ##
===========================================
- Coverage 93.61% 74.86% -18.75%
===========================================
Files 101 101
Lines 22120 22129 +9
===========================================
- Hits 20707 16567 -4140
- Misses 1413 5562 +4149
|
ricardoV94
requested changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but I would rather keep the old check than the new one. What do you think?
ricardoV94
reviewed
Oct 20, 2022
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
ricardoV94
approved these changes
Oct 20, 2022
ricardoV94
changed the title
Fix test component choice random
Fix flaky test component choice random
Oct 20, 2022
ricardoV94
changed the title
Fix flaky test component choice random
Fix flaky Oct 20, 2022
TestMixture.test_component_choice_random
Thanks @bherwerth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Fixes #6210:
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance
TestMixture.test_component_choice_random