Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old or unused Model methods #6237

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Deprecate old or unused Model methods #6237

merged 8 commits into from
Oct 21, 2022

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 20, 2022 •
edited
Loading

Closes #5859

Major / Breaking Changes

  • Deprecate several methods from Model class

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

@ricardoV94 ricardoV94 added maintenance major Include in major changes release notes section labels Oct 20, 2022
@ricardoV94 ricardoV94 changed the title Deprecate old methods Deprecate old or unused Model methods Oct 20, 2022
twiecki
twiecki reviewed Oct 20, 2022
View reviewed changes
pymc/model.py Outdated Show resolved Hide resolved
twiecki
twiecki reviewed Oct 20, 2022
View reviewed changes
pymc/model.py Show resolved Hide resolved
@ricardoV94 ricardoV94 force-pushed the deprecate_old_methods branch from d1a4b1c to dd71d58 Compare October 20, 2022 14:47
@ricardoV94 ricardoV94 force-pushed the deprecate_old_methods branch from dd71d58 to 9ddc161 Compare October 20, 2022 15:14
@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #6237 (9ddc161) into main (7503730) will decrease coverage by 0.13%.
The diff coverage is 94.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6237      +/-   ##
==========================================
- Coverage   93.61%   93.47%   -0.14%     
==========================================
  Files         101      101              
  Lines       22120    22081      -39     
==========================================
- Hits        20707    20641      -66     
- Misses       1413     1440      +27
Impacted Files Coverage Δ
pymc/aesaraf.py 93.54% <ø> (ø)
pymc/tuning/scaling.py 62.74% <66.66%> (+3.48%) ⬆️
pymc/model.py 89.47% <96.42%> (+1.20%) ⬆️
pymc/step_methods/hmc/base_hmc.py 90.55% <100.00%> (ø)
pymc/step_methods/metropolis.py 83.40% <100.00%> (ø)
pymc/step_methods/slicer.py 96.20% <100.00%> (ø)
pymc/tuning/starting.py 92.50% <100.00%> (ø)
pymc/tests/step_methods/test_compound.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/backends/test_arviz.py 99.02% <0.00%> (+0.01%) ⬆️
... and 1 more

michaelosthege
michaelosthege approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests being flaky again.

LGTM

@ricardoV94 ricardoV94 merged commit 2813811 into pymc-devs:main Oct 21, 2022
@ricardoV94 ricardoV94 mentioned this pull request Nov 3, 2022
Closed
@ricardoV94 ricardoV94 deleted the deprecate_old_methods branch November 4, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelosthege michaelosthege michaelosthege approved these changes

@twiecki twiecki twiecki approved these changes

@ferrine ferrine Awaiting requested review from ferrine

Assignees
No one assigned
Labels
major Include in major changes release notes section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove t suffix from Model methods
3 participants
@ricardoV94 @twiecki @michaelosthege