Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not infer graph_model node types based on variable Op class #6259

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

ricardoV94
Copy link
Member

Closes #5766

Major / Breaking Changes

  • ...

Bugfixes / New features

  • Do not show SymbolicRandomVariables as deterministics in model_graph

Docs / Maintenance

  • ...

@ricardoV94 ricardoV94 changed the title Do not infer graph_model node types based on variable Op class Do not infer graph_model node types based on variable Op class Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #6259 (8084ef8) into main (b0d1066) will increase coverage by 29.80%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6259       +/-   ##
===========================================
+ Coverage   64.39%   94.20%   +29.80%     
===========================================
  Files         101      102        +1     
  Lines       21465    21472        +7     
===========================================
+ Hits        13823    20227     +6404     
+ Misses       7642     1245     -6397     
Impacted Files Coverage Δ
pymc/model_graph.py 78.82% <100.00%> (+12.15%) ⬆️
pymc/tests/stats/test_convergence.py 100.00% <0.00%> (ø)
pymc/model.py 89.47% <0.00%> (+0.27%) ⬆️
pymc/step_methods/metropolis.py 83.47% <0.00%> (+0.41%) ⬆️
pymc/distributions/shape_utils.py 97.85% <0.00%> (+0.42%) ⬆️
pymc/math.py 70.04% <0.00%> (+0.48%) ⬆️
pymc/distributions/distribution.py 95.00% <0.00%> (+2.27%) ⬆️
pymc/aesaraf.py 94.04% <0.00%> (+2.33%) ⬆️
pymc/tests/distributions/util.py 90.86% <0.00%> (+2.46%) ⬆️
pymc/backends/arviz.py 90.08% <0.00%> (+4.54%) ⬆️
... and 57 more

@ricardoV94 ricardoV94 merged commit 48664c0 into pymc-devs:main Nov 3, 2022
@ricardoV94 ricardoV94 deleted the fix_symbolic_rvs_graphviz branch November 4, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZeroInflatedPoisson and ZeroInflatedNegativeBinomial show up as Deterministic on graphviz
2 participants