Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared variable latex #6260

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

ricardoV94
Copy link
Member

Closes #6253
...

Major / Breaking Changes

  • ...

Bugfixes / New features

  • Fix error in string and latex representation of shared inputs

Docs / Maintenance

  • ...

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #6260 (4262bdc) into main (b0d1066) will increase coverage by 25.55%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6260       +/-   ##
===========================================
+ Coverage   64.39%   89.95%   +25.55%     
===========================================
  Files         101      102        +1     
  Lines       21465    21478       +13     
===========================================
+ Hits        13823    19321     +5498     
+ Misses       7642     2157     -5485     
Impacted Files Coverage Δ
pymc/printing.py 87.90% <100.00%> (+63.53%) ⬆️
pymc/tests/stats/test_convergence.py 100.00% <0.00%> (ø)
pymc/model.py 89.47% <0.00%> (+0.27%) ⬆️
pymc/step_methods/metropolis.py 83.47% <0.00%> (+0.41%) ⬆️
pymc/math.py 70.04% <0.00%> (+0.48%) ⬆️
pymc/distributions/distribution.py 95.00% <0.00%> (+2.27%) ⬆️
pymc/aesaraf.py 94.04% <0.00%> (+2.33%) ⬆️
pymc/tests/distributions/util.py 90.86% <0.00%> (+2.46%) ⬆️
pymc/backends/arviz.py 90.08% <0.00%> (+4.54%) ⬆️
pymc/distributions/logprob.py 91.09% <0.00%> (+4.79%) ⬆️
... and 51 more

@ricardoV94
Copy link
Member Author

Failing test seems unrelated

Copy link
Member

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ricardoV94 ricardoV94 merged commit fd5a6cc into pymc-devs:main Nov 3, 2022
@ricardoV94 ricardoV94 deleted the fix_shared_variable_latex branch November 4, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model string representations may fail when using a shared variable
3 participants