Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pymc.DiscreteWeibull docstring #6283

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Updated pymc.DiscreteWeibull docstring #6283

merged 2 commits into from
Nov 10, 2022

Conversation

hyosubkim
Copy link
Contributor

What is this PR about?
...Added parameter descriptions to docstring and other minor edits.

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

Note: I am not fully confident in nomenclature for q parameter. Some resources call it a 'shape' parameter, so I went with that.

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs a couple changes (see comments below) but otherwise looks good doc-wise.

Can someone familiar with the distribution review the parameter descriptions? Having 2 shape parameters sounds a bit strange but I don't really know what each of them means.

pymc/distributions/discrete.py Outdated Show resolved Hide resolved
pymc/distributions/discrete.py Outdated Show resolved Hide resolved
@michaelosthege
Copy link
Member

Thanks for fixing it, @hyosubkim !

@michaelosthege michaelosthege merged commit d4b5aa8 into pymc-devs:main Nov 10, 2022
@hyosubkim
Copy link
Contributor Author

Absolutely! Thanks for the help in reviewing. Looking forward to pitching in some more.

@hyosubkim hyosubkim deleted the docstring_update branch November 10, 2022 22:34
wrongu pushed a commit to wrongu/pymc that referenced this pull request Dec 1, 2022
* Updated pymc.DiscreteWeibull docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants