Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve random seed processing for SMC sampling #6298

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Nov 14, 2022

What is this PR about?

Closes: #6258

Checklist

@juanitorduz juanitorduz changed the title improve random seed processing improve random seed processing smc sampling Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #6298 (c25ab22) into main (5d7283e) will decrease coverage by 14.33%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6298       +/-   ##
===========================================
- Coverage   94.12%   79.78%   -14.34%     
===========================================
  Files         111      111               
  Lines       23861    23852        -9     
===========================================
- Hits        22458    19031     -3427     
- Misses       1403     4821     +3418     
Impacted Files Coverage Δ
pymc/smc/sampling.py 86.42% <100.00%> (+3.20%) ⬆️
pymc/tests/distributions/test_continuous.py 0.00% <0.00%> (-99.77%) ⬇️
pymc/tests/distributions/test_multivariate.py 0.00% <0.00%> (-99.46%) ⬇️
pymc/tests/distributions/test_discrete.py 0.00% <0.00%> (-98.89%) ⬇️
pymc/tests/distributions/test_distribution.py 0.00% <0.00%> (-98.17%) ⬇️
pymc/tests/distributions/util.py 43.70% <0.00%> (-47.17%) ⬇️
pymc/distributions/multivariate.py 57.77% <0.00%> (-34.51%) ⬇️
pymc/distributions/discrete.py 64.85% <0.00%> (-34.37%) ⬇️
pymc/distributions/continuous.py 65.31% <0.00%> (-32.20%) ⬇️
pymc/distributions/transforms.py 85.00% <0.00%> (-15.00%) ⬇️
... and 8 more

@twiecki twiecki requested a review from aloctavodia November 14, 2022 10:03
@ricardoV94 ricardoV94 added SMC Sequential Monte Carlo maintenance labels Nov 14, 2022
@michaelosthege michaelosthege changed the title improve random seed processing smc sampling Improve random seed processing smc sampling Nov 14, 2022
@michaelosthege michaelosthege changed the title Improve random seed processing smc sampling Improve random seed processing for SMC sampling Nov 14, 2022
@michaelosthege michaelosthege merged commit d36bed3 into pymc-devs:main Nov 14, 2022
wrongu pushed a commit to wrongu/pymc that referenced this pull request Dec 1, 2022
* improve random seed processing
* improve type-hint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance SMC Sequential Monte Carlo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use _get_seeds_per_chain utility in smc/sampling.py
4 participants