Bugfixes to increase robustness against unnamed dims
#6339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
commented
Nov 27, 2022
Comment on lines
+209
to
+212
| # TODO: Evaluate all RV shapes and dim_length at once. | ||
| # This should help to find discrepancies, and | ||
| # avoids unncessary function compiles for deetermining labels. | ||
|
|
There was a problem hiding this comment.
This is not needed for the bugfix, but I commented it here for the next person touching this code.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6339 +/- ##
=======================================
Coverage 94.14% 94.15%
=======================================
Files 132 132
Lines 26714 26726 +12
=======================================
+ Hits 25150 25163 +13
+ Misses 1564 1563 -1
|
ricardoV94
requested changes
Nov 27, 2022
pymc/model.py
Outdated
| @@ -1507,7 +1509,7 @@ def add_named_variable(self, var, dims: Optional[Tuple[Union[str, None], ...]] = | |||
| for dim in dims: | |||
| if dim not in self.coords and dim is not None: | |||
| raise ValueError(f"Dimension {dim} is not specified in `coords`.") | |||
| if any(var.name == dim for dim in dims): | |||
| if any(var.name == dim != None for dim in dims): | |||
There was a problem hiding this comment.
Suggested change
| if any(var.name == dim != None for dim in dims): | |
| if any(var.name == dim for dim in dims if dim is not None): |
There was a problem hiding this comment.
My code worked too, but OK let's have it your way ;)
michaelosthege
force-pushed
the
issue-6335
branch
from
62906bf to
01fb0a8
Compare
ricardoV94
pushed a commit
to michaelosthege/pymc
that referenced
this pull request
Nov 29, 2022
* Extract `ModelGraph._eval` to a function * More robustness against unlabeled `dims` entries Closes pymc-devs#6335
ricardoV94
pushed a commit
to ricardoV94/pymc
that referenced
this pull request
Nov 29, 2022
* Extract `ModelGraph._eval` to a function * More robustness against unlabeled `dims` entries Closes pymc-devs#6335
wrongu
pushed a commit
to wrongu/pymc
that referenced
this pull request
Dec 1, 2022
* Extract `ModelGraph._eval` to a function * More robustness against unlabeled `dims` entries Closes pymc-devs#6335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the two bugs I described in #6335.
Essentially two
Model.get_platesandModel.add_named_variablemethods did not anticipate that elements of adimstuple can beNone.I added some comments to the refactored code and tests.
Checklist
Major / Breaking Changes
Bugfixes / New features
pm.model_to_graphvizandModel.add_named_variablethat were triggered byNoneelements indimstuples.Docs / Maintenance