Simplify measurable transform rewrites #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
simplify_measurable_transform_rewrites
branch
from
843e8d6 to
9bd018d
Compare
|
I would like to get this one merged before the group hackathon tomorrow. Will make it easier to review the other more-interesting PRs |
ricardoV94
force-pushed
the
simplify_measurable_transform_rewrites
branch
from
9bd018d to
0d21996
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6370 +/- ##
===========================================
- Coverage 94.72% 80.72% -14.00%
===========================================
Files 132 131 -1
Lines 26742 26672 -70
===========================================
- Hits 25331 21531 -3800
- Misses 1411 5141 +3730
|
twiecki
approved these changes
Dec 5, 2022
These should have been provided as keyword arguments, but they don't seem to matter anyway
This functionality was not being used by PyMC. In theory, it could be used to cache one type of transformed RV Op instead of recreating it for every instance of the same RV + transform, resulting in a faster logp rewrite (?). We can always revisit this idea later, but for now it unnecessarily complicated our codebase.
ricardoV94
force-pushed
the
simplify_measurable_transform_rewrites
branch
from
0d21996 to
e11b576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some cleanup of the logprob submodule, removing functionality we don't need or are not using in PyMC
Closes #6353