Remove global RandomStream #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6396 +/- ##
=======================================
Coverage 94.79% 94.80%
=======================================
Files 148 148
Lines 27488 27477 -11
=======================================
- Hits 26058 26049 -9
+ Misses 1430 1428 -2
|
ricardoV94
force-pushed
the
remote_at_rng
branch
from
fe606ec to
72dcdcf
Compare
ricardoV94
commented
Dec 14, 2022
Comment on lines
+135
to
+138
| def make_node(self, rng, *args, **kwargs): | ||
| if rng is None: | ||
| rng = pytensor.shared(np.random.default_rng()) | ||
| return super().make_node(rng, *args, **kwargs) |
There was a problem hiding this comment.
Can be removed once pymc-devs/pytensor#97 is solved
ricardoV94
force-pushed
the
remote_at_rng
branch
from
72dcdcf to
0009ff3
Compare
ferrine
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer needed after #6304