Update PyTensor dependency and fix bugs in inferred mixture logprob #6397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
approved these changes
Dec 14, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6397 +/- ##
==========================================
+ Coverage 94.79% 94.81% +0.01%
==========================================
Files 148 148
Lines 27488 27559 +71
==========================================
+ Hits 26058 26129 +71
Misses 1430 1430
|
ricardoV94
force-pushed
the
update_pytensor_dependency
branch
3 times, most recently
from
d776233 to
a051e58
Compare
ricardoV94
force-pushed
the
update_pytensor_dependency
branch
from
a051e58 to
31080c6
Compare
It did not account for the extra dimension added by the stacking operation, resulting in a logp call to an expanded RV with the original unexpanded value
Now that Dimshuffle lift broadcasts both the parameters and the size, the AdvancedIndexing logprob fails most of the times, even though these are valid graphs. All but one of the failing cases can be helped by introducing the local_rv_size_lift rewrite.
ricardoV94
force-pushed
the
update_pytensor_dependency
branch
from
31080c6 to
b54b2d8
Compare
ricardoV94
changed the title
|
I had to patch quite some things with the inferred mixture logprob. Most of these cases won't be supported after #6369 but we haven't merged that yet |
|
Why don't we? |
Merge? The fixes done here are actually more correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need to wait for the conda-forge release