Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default VonMises kappa to 1.0 and fix math notation in doc #6419

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Dec 28, 2022

What is this PR about?
This PR fixes the default value concern raised in the issue here. The docs are also adjusted.

Checklist

Major / Breaking Changes

  • None

New features

  • VonMises without args will allow sampling

Bugfixes

  • pm.draw, pm.sample... will now produce sample with defaults / no args in VonMises distribution

Documentation

  • The math will render now. Defaults now updated

Maintenance

  • ...

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 28, 2022

I didn't see any tests for checking the samples, draws, etc of the VonMises distribution. The tests that I did see provided a kappa all that were not the prior default (None)

If there is a place someone feels appropriate to add an additional test, let me know.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #6419 (a3ffc56) into main (a079153) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6419   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         148      148           
  Lines       27645    27645           
=======================================
  Hits        26190    26190           
  Misses       1455     1455           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.68% <100.00%> (ø)

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we don't need a test for this one, I don't think we test default parameters anywhere else

@ricardoV94 ricardoV94 changed the title make default 1.0 and fix math notation in doc Default VonMises kappa to 1.0 and fix math notation in doc Dec 28, 2022
@wd60622
Copy link
Contributor Author

wd60622 commented Dec 28, 2022

New docs

von-mises-new-docs

@ricardoV94 ricardoV94 merged commit a7f361b into pymc-devs:main Dec 29, 2022
@ricardoV94
Copy link
Member

Thanks @wd60622 !

@wd60622 wd60622 deleted the vonmises_default branch July 27, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants