-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are no longer part of the package #6540
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6540 +/- ##
==========================================
- Coverage 94.73% 91.93% -2.80%
==========================================
Files 147 89 -58
Lines 27951 14933 -13018
==========================================
- Hits 26479 13729 -12750
+ Misses 1472 1204 -268 |
9776990
to
c46b74d
Compare
Don't know if we should label this as major, for those people who run tests when they install the package. |
ef55a82
to
1ef1f95
Compare
A conflict seems to have cropped up, looks good to me otherwise |
@OriolAbril is the RTD failure new? It's not the usual timeout that was going on for a while |
1ef1f95
to
e80eae7
Compare
The rtd error says it is due to an error when executing tge posterior predictive notebook, specifically in the pm.get_data line |
Indeed, thank you! I found the mistake. |
e80eae7
to
e7d0996
Compare
Fixes #6526, as discussed in #6172.
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance