Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are no longer part of the package #6540

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

Armavica
Copy link
Member

Fixes #6526, as discussed in #6172.

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • Move the tests outside of the code directory.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #6540 (e80eae7) into main (562e51e) will decrease coverage by 2.80%.
The diff coverage is n/a.

❗ Current head e80eae7 differs from pull request most recent head e7d0996. Consider uploading reports for the commit e7d0996 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6540      +/-   ##
==========================================
- Coverage   94.73%   91.93%   -2.80%     
==========================================
  Files         147       89      -58     
  Lines       27951    14933   -13018     
==========================================
- Hits        26479    13729   -12750     
+ Misses       1472     1204     -268     
Impacted Files Coverage Δ
pymc/data.py 88.43% <0.00%> (-1.74%) ⬇️
tests/backends/fixtures.py
tests/backends/test_arviz.py
tests/backends/test_base.py
tests/backends/test_ndarray.py
tests/distributions/test_bound.py
tests/distributions/test_censored.py
tests/distributions/test_continuous.py
tests/distributions/test_discrete.py
tests/distributions/test_dist_math.py
... and 49 more

@Armavica Armavica force-pushed the tests-outside-of-pymc branch from 9776990 to c46b74d Compare February 21, 2023 02:23
@Armavica Armavica marked this pull request as ready for review February 21, 2023 04:06
@Armavica Armavica requested a review from ricardoV94 February 21, 2023 04:06
@ricardoV94
Copy link
Member

Don't know if we should label this as major, for those people who run tests when they install the package.

@Armavica Armavica force-pushed the tests-outside-of-pymc branch 3 times, most recently from ef55a82 to 1ef1f95 Compare February 21, 2023 19:27
@Armavica Armavica added the major Include in major changes release notes section label Feb 22, 2023
@Armavica Armavica requested a review from ricardoV94 February 22, 2023 02:20
@ricardoV94 ricardoV94 changed the title Move tests outside of code directory Tests are no longer part of the package Feb 22, 2023
@ricardoV94
Copy link
Member

A conflict seems to have cropped up, looks good to me otherwise

@ricardoV94
Copy link
Member

@OriolAbril is the RTD failure new? It's not the usual timeout that was going on for a while

@Armavica Armavica force-pushed the tests-outside-of-pymc branch from 1ef1f95 to e80eae7 Compare February 22, 2023 19:02
@OriolAbril
Copy link
Member

The rtd error says it is due to an error when executing tge posterior predictive notebook, specifically in the pm.get_data line

@Armavica
Copy link
Member Author

The rtd error says it is due to an error when executing tge posterior predictive notebook, specifically in the pm.get_data line

Indeed, thank you! I found the mistake.

@Armavica Armavica force-pushed the tests-outside-of-pymc branch from e80eae7 to e7d0996 Compare February 22, 2023 20:17
@ricardoV94 ricardoV94 merged commit e1d36ca into pymc-devs:main Feb 22, 2023
@Armavica Armavica deleted the tests-outside-of-pymc branch October 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance major Include in major changes release notes section tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the tests directory outside of the code directory
3 participants