Exclude tests from package discovery

[Armavica]

setuptools was now picking up the tests directory as an installable package and was installing it alongside pymc, which could conflict with any other package named tests.

This PR configures setuptools to exclude tests from the automated package discovery.

I took this opportunity to clean up some warning-generating lines in MANIFEST.in, and an unused option in setup.py.

Checklist

• Explain important implementation details 👆
• Make sure that the pre-commit linting/style checks pass.
• Link relevant issues (preferably in nice commit messages)
• Are the changes covered by tests and docstrings?
• Fill out the short summary sections 👇

Major / Breaking Changes

• ...

New features

• ...

Bugfixes

• ...

Documentation

• ...

Maintenance

• Exclude tests from the package discovery

[codecov]

Codecov Report

Merging #6552 (d107a39) into main (2f945bb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6552      +/-   ##
==========================================
- Coverage   92.01%   92.01%   -0.01%     
==========================================
  Files          91       91              
  Lines       15114    15108       -6     
==========================================
- Hits        13907    13901       -6     
  Misses       1207     1207              

Impacted Files	Coverage Δ
pymc/data.py	89.82% <100.00%> (-0.36%)	⬇️

[ricardoV94]

Can we just move the relevant test utils TestMatchesScipy into the pymc package like numpy.testing module and leave tests outside? Wondering if that could be easier?

[Armavica]

Can we just move the relevant test utils TestMatchesScipy into the pymc package like numpy.testing module and leave tests outside? Wondering if that could be easier?

Yeah, much easier indeed. I will do that then, thanks :)

[Armavica]

I repurposed this PR to only fix the spurious tests package installation so that we can re-release quickly: the pymc-experimental dependency is less urgent because they install from git, so they don't depend on a release.

[ricardoV94]

Might have broken ReadTheDocs?

[OriolAbril]

Same issue on test_scores = pd.read_csv(pm.get_data("test_scores.csv"), index_col=0) line as in the other PR that moved tests

[Armavica]

I fixed it. The problem was that pm.get_data was first looking inside tests/data, which used to contain example files. This directory doesn't exist anymore, since 759acb0, so I believe that the fallback (downloading from github pymc-examples) is now always activated since then. So I just removed the local check.

[twiecki]

Doesn't this exclude other stuff like example NBs or csv files?

[Armavica]

There is no more csv files in pymc (I think they moved to pymc-examples), and if NBs were ever included, I don't think they are not anymore. As far as I can say, building pymc with or without this line creates the same wheel.

[twiecki]

Thanks for the quick turn-around @Armavica! Should we release 5.1.1 now?

[ricardoV94]

@twiecki let's add back the test utilities that are used by other packages first. I'll push a PR now