Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TruncatedNormal only accepts mu and sigma as non keyword arguments #6568

Merged

Conversation

michaelraczycki
Copy link
Contributor

What is this PR about?
Making params of TruncatedNormal distribution to avoid issues with icdf testing.

Checklist

Major / Breaking Changes

New features

Bugfixes

Documentation

Changes are self descriptive

Maintenance

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #6568 (4643a1b) into main (31c30dc) will decrease coverage by 31.37%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6568       +/-   ##
===========================================
- Coverage   94.73%   63.37%   -31.37%     
===========================================
  Files         147       91       -56     
  Lines       27864    15114    -12750     
===========================================
- Hits        26398     9578    -16820     
- Misses       1466     5536     +4070     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.68% <ø> (ø)
pymc/ode/utils.py 15.62% <0.00%> (-84.38%) ⬇️
pymc/smc/kernels.py 19.34% <0.00%> (-78.11%) ⬇️
pymc/logprob/scan.py 19.57% <0.00%> (-77.78%) ⬇️
pymc/gp/gp.py 18.76% <0.00%> (-75.07%) ⬇️
pymc/logprob/mixture.py 24.72% <0.00%> (-73.63%) ⬇️
pymc/variational/updates.py 21.67% <0.00%> (-70.45%) ⬇️
pymc/func_utils.py 18.60% <0.00%> (-69.77%) ⬇️
pymc/gp/cov.py 29.15% <0.00%> (-68.94%) ⬇️
pymc/printing.py 19.35% <0.00%> (-68.55%) ⬇️
... and 121 more

@ricardoV94 ricardoV94 changed the title changed params after sigma to kwarg only TruncatedNormal now only accepts mu and sigma as non keyword arguments Mar 6, 2023
@ricardoV94 ricardoV94 changed the title TruncatedNormal now only accepts mu and sigma as non keyword arguments TruncatedNormal only accepts mu and sigma as non keyword arguments Mar 6, 2023
@ricardoV94 ricardoV94 merged commit 8208291 into pymc-devs:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants