-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove auto
argument from pm.Deterministic
docstring
#6592
Remove auto
argument from pm.Deterministic
docstring
#6592
Conversation
Can you add the missing ones and format it according to the numpydoc style guide? |
Sure! I'll add the params |
sure |
Thanks @shreyas3156 for this PR!
Just for some additional pointers, you can take inspiration from some of the docstrings that are available in the same file: Lines 1921 to 1922 in b5fa488
Lines 1300 to 1301 in b5fa488
(A note aside is that I'm noticing that many of other docstrings could be updated... that'll be for another issue) Edit: Didn't see the fast responses above when typing this... |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6592 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 92 92
Lines 15535 15539 +4
=======================================
+ Hits 14297 14302 +5
+ Misses 1238 1237 -1
|
Thank you for the reference! @michaelosthege @larryshamalama I've added the args and made a few changes as per the style guide. Please review and let me know your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you for this PR @shreyas3156! You're on a roll with these PRs!
There's a slight pre-commit error, but I believe that it was recently introduced and fixed. If you're not familiar with pre-commit, @ricardoV94 gave me some nice pointers 2 years ago that helped a lot. I'm just mentioning this in case this could also help you later down the line :)
Thank you for this suggestion! I could get a better context of
Glad I could contribute :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that whitespace change was fixed on another PR and we can override here.
Thanks @shreyas3156 !
What is this PR about?
Closes #6588
Removed the
auto
argument from the docstring ofpm.Deterministic
as it was removed in the cleanup in #6309Checklist