Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probabilty inference for arc transformations #6775

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

LukeLB
Copy link
Contributor

@LukeLB LukeLB commented Jun 12, 2023

Users have asked for the ability to use aditional transformations #6631, also see https://discourse.pymc.io/t/the-sinh-arcsinh-normal-distribution/12136. This ended up being quite fast as the logic is very similar to many of the previous transforms I've implemented.

I've added these transforms to the existing tests, which pass. However, it seems there are a few tests that aren't passing in tests/logprob/test_transform.py. I think they may have been failing prior to me, as they fail on main as well....

...

Checklist

New features

  • Arcsinh transform
  • Arccosh transform
  • Arctanh transform

📚 Documentation preview 📚: https://pymc--6775.org.readthedocs.build/en/6775/

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #6775 (5dd3b02) into main (154f5b0) will decrease coverage by 0.69%.
The diff coverage is 86.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6775      +/-   ##
==========================================
- Coverage   91.89%   91.21%   -0.69%     
==========================================
  Files          95       95              
  Lines       16147    16168      +21     
==========================================
- Hits        14839    14747      -92     
- Misses       1308     1421     +113     
Impacted Files Coverage Δ
pymc/logprob/transforms.py 94.24% <86.95%> (-0.36%) ⬇️

... and 4 files with indirect coverage changes

@ricardoV94 ricardoV94 changed the title New arc transforms added Probabilty inference for arc transformations Jun 13, 2023
@ricardoV94
Copy link
Member

ricardoV94 commented Jun 13, 2023

@LukeLB which tests failed exactly? There were some jobs that for some reason were cancelled and didn't run. I restarted them manually now.

@LukeLB
Copy link
Contributor Author

LukeLB commented Jun 13, 2023

Faiures are below:
FAILED test_transforms.py::test_reciprocal_rv_transform - AttributeError: module 'pytensor.tensor' has no attribute 'get_underlying_scalar_constant_value'
FAILED test_transforms.py::test_sqr_transform - AttributeError: module 'pytensor.tensor' has no attribute 'get_underlying_scalar_constant_value'
FAILED test_transforms.py::test_negative_value_odd_power_transform - AttributeError: module 'pytensor.tensor' has no attribute 'get_underlying_scalar_constant_value'
FAILED test_transforms.py::test_scan_transform - AttributeError: 'NoneType' object has no attribute 'inputs'

EDIT: Ah this will be an envrironment thing I bet! Will try with new env
EDIT2: Yep that was it, all tests pass locally. I should learn to update my environment more frequently!

@ricardoV94
Copy link
Member

Let me know if it works and if you think we should merge

@ricardoV94 ricardoV94 merged commit c792e88 into pymc-devs:main Jun 14, 2023
@ricardoV94
Copy link
Member

Thanks @LukeLB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants