Fix issue with sampling of PartialObservedRVs #7071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was issue with PartialObservedRVs in that we used the same RNG in two places: in one of the masked RVs and in the shape of the empty tensor where the two masked RVs are stored as a deterministic.
This would further raise an error in JAX when computing the joined deterministic, because we don't allow RNGs in jaxified graphs.
Constant folding will ensure the shape graph will be introduced instead of the default
ShapeOp(RV)
so the RNG shouldn't be part of that deterministic graph.Related Issue
Issue reported in https://discourse.pymc.io/t/shared-randomtype-issue-using-nuts-numpyro-w-r-t-data-containing-nans/13503?u=ricardov94
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7071.org.readthedocs.build/en/7071/