Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compute_log_prior utility #7149

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

aloctavodia
Copy link
Member

@aloctavodia aloctavodia commented Feb 12, 2024

Add compute_log_prior function. the log_prior values are needed for prior sensitivity checks as described in this paper https://arxiv.org/abs/2107.14054. Part of the functionality described in that paper is already implemented in ArviZ.


📚 Documentation preview 📚: https://pymc--7149.org.readthedocs.build/en/7149/

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this all be implemented in the same file?

@aloctavodia
Copy link
Member Author

aloctavodia commented Feb 12, 2024

sure, we just need to rename log_likelihood.py to log_density.py or something similar and fix a few imports.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (627a8dd) 90.41% compared to head (47025f0) 91.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7149      +/-   ##
==========================================
+ Coverage   90.41%   91.92%   +1.50%     
==========================================
  Files         101      101              
  Lines       16930    16945      +15     
==========================================
+ Hits        15308    15576     +268     
+ Misses       1622     1369     -253     
Files Coverage Δ
pymc/stats/__init__.py 100.00% <100.00%> (ø)
pymc/stats/log_density.py 98.30% <96.55%> (ø)
pymc/backends/arviz.py 96.07% <60.00%> (-0.93%) ⬇️

... and 10 files with indirect coverage changes

@aloctavodia aloctavodia merged commit ae5a943 into pymc-devs:main Feb 13, 2024
23 checks passed
@aloctavodia aloctavodia deleted the log_prior branch February 13, 2024 12:24
@ricardoV94 ricardoV94 changed the title add compute_log_prior Implement compute_log_prior utility Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants