Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compute_log_prior in models with Deterministics #7168

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Feb 22, 2024

Description

The default for var_names in compute_log_likelihood was unobserved_RVs which
includes also deterministics. This changes the default to free_RVs.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7168.org.readthedocs.build/en/7168/

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97a7a00) 92.29% compared to head (34d2a5d) 92.29%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7168   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         101      101           
  Lines       16947    16947           
=======================================
  Hits        15642    15642           
  Misses       1305     1305           
Files Coverage Δ
pymc/stats/log_density.py 98.30% <100.00%> (ø)

@ricardoV94 ricardoV94 added the bug label Feb 22, 2024
@ricardoV94 ricardoV94 changed the title fix compute_log_prior default var_names Fix compute_log_prior in models with Deterministics Feb 22, 2024
@ricardoV94 ricardoV94 merged commit 74748c7 into pymc-devs:main Feb 22, 2024
23 checks passed
@OriolAbril OriolAbril deleted the log_prior branch February 22, 2024 17:59
mkusnetsov pushed a commit to mkusnetsov/pymc that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants