-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add introduction section to Transformations API page to document role of Transforms #7232
Conversation
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explanation is absolutely incredible!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion, as you mentioned we will have both transform
and default_transform
after: #7207
All you said about default_transform
is correct. When users want to add other constraints but not modify the default one, they should probably use the transform
kwarg. Under the hood, we will build a ChainTransform, that applies the user provided transform on top of the default one.
Thanks, @ricardoV94! That's a good point - I pushed some changes to clarify But I might be doing something wrong? Although I can see the commits and the changes, the preview documentation is still showing the original version, not the revised one... (I know it takes a while to re-build but it seems to be saying "Read the Docs build succeeded!") |
It takes some time for the preview to update. I think it's correct now? https://pymcio--7232.org.readthedocs.build/projects/docs/en/7232/api/distributions/transforms.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is perfect as is. I would just wait for the related PR to be merged, so that our docs are not "ahead of time"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7232 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 100 100
Lines 16895 16895
=======================================
Hits 15595 15595
Misses 1300 1300
|
Thank you for the kind words! It is correct now, yes. Will know that it takes a while, in the future. And yes - it absolutely makes sense to wait for the other PR. I left some open questions on the underlying issue. Are any of them worth pursuing either in a separate issue or a discussion? Just checking because I assume once that issue is closed they might get lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I review docs related PRs quite sparsely if I have time and after seeing this one I wanted to add my praise too at use of rST, both at syntax level and conceptual level 😄 📚
Also, in case someone wonders, the fact that references to pymc.sample, pymc.sample_prior_predictive... are not (yet) rendered as links in the rtd preview is an issue with how those are documented, once that is fixed all cross-references here will work
Thanks a ton @mkusnetsov, don't hesitate in opening issues/PRs for other areas you find documentation to be lacking |
Description
This PR adds an introduction section to the Transformations API page to:
In addition this PR:
ordered
transform (I think it was accidentally left over from whenunivariate_ordered
was deprecated)SumsTo1
, which is being deprecatedThis PR assumes that the issue #5674 is closed (via PR #7207) to avoid extensive (and somewhat non-intuitive to casual user) guidance that will shortly be outdated
Related Issue
default_transform
andtransform
argument for distributions #5674, Deprecate SumTo1 Transform #7009Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7232.org.readthedocs.build/en/7232/