Fix need for dummy data in sample_posterior_predictive
#7265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
fix_dummy_data
branch
2 times, most recently
from
94cc61d to
309139b
Compare
ricardoV94
changed the title
sample_posterior_predictive
ricardoV94
commented
May 3, 2024
| @@ -454,7 +454,7 @@ def test_constant_data(self, use_context): | |||
| test_dict = { | |||
| "posterior": ["beta"], | |||
| "observed_data": ["obs"], | |||
| "constant_data": ["x", "y", "beta_sigma"], | |||
| "constant_data": ["x", "beta_sigma"], | |||
There was a problem hiding this comment.
This y was in fact observed data... Now nothing stops the user from using y both as observed data and constant data, so I am not sure we want to truly remove it.
We can check if y shows up in the generative graph.
11 tasks
This avoids needing to set dummy observed data when doing sample_posterior_predictive when that is not part of the generative graph.
|
Let's get this merged? The CI failure looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix arviz backend find_constants
This also fixes a bug when doing sample_posterior_predictive with resized X data, where the old unused Y data would be retrieved and a dimension mismatch would crop up, unless a dummy Y was set prior to sampling.
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7265.org.readthedocs.build/en/7265/