Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time remaining column to progress bars #7273

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Apr 21, 2024

Description

Adds TimeRemainingColumn to progress bar where appropriate, also properly hides progressbar during sample_posterior_predictive

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7273.org.readthedocs.build/en/7273/

@fonnesbeck fonnesbeck requested a review from ricardoV94 April 21, 2024 22:09
@ricardoV94
Copy link
Member

While we're here can we also try to fix #7264 ?

This issue suggests there should be transient flag we can play with? Textualize/rich#110

@fonnesbeck
Copy link
Member Author

Will try and fix #7278 here as well.

@fonnesbeck
Copy link
Member Author

image

@ricardoV94
Copy link
Member

Branch seems to have some conflicts?

@ricardoV94 ricardoV94 requested a review from zaxtax April 25, 2024 16:52
@ricardoV94 ricardoV94 added the bug label Apr 25, 2024
Copy link
Contributor

@zaxtax zaxtax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. After my comment is addressed should be good to merge.

pymc/backends/arviz.py Outdated Show resolved Hide resolved
@fonnesbeck fonnesbeck requested a review from ricardoV94 April 26, 2024 12:51
Copy link
Contributor

@zaxtax zaxtax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fonnesbeck fonnesbeck merged commit 60a6314 into pymc-devs:main Apr 26, 2024
21 checks passed
mkusnetsov pushed a commit to mkusnetsov/pymc that referenced this pull request Oct 26, 2024
* Add time remaining column to progress bars

* Consistent order remaining/elapsed

* Disable sample_posterior_predictive taskbar when progressbar=False

* Formatting

* More formatting

* More formatting (why doesnt pre-commit fix this?)

* Disable progress bar when progress=False

* Set refresh flag in progress bar updates

* Typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants