Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mypy and versioneer settings to pyproject.toml #7382

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Jun 22, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7382.org.readthedocs.build/en/7382/

@Armavica Armavica changed the title Move everything to pyproject.toml Move tools and build system to pyproject.toml Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (1b67888) to head (0e984d0).
Report is 91 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7382   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         103      103           
  Lines       17258    17258           
=======================================
  Hits        15909    15909           
  Misses       1349     1349           

@Armavica Armavica marked this pull request as ready for review June 22, 2024 04:11
@Armavica Armavica requested a review from maresb June 22, 2024 04:12
@maresb
Copy link
Contributor

maresb commented Jun 22, 2024

I took a very quick look. Very exciting, but there's a problem:

$ python -m build .
...
Successfully built pymc-0.0.0.tar.gz and pymc-0.0.0-py3-none-any.whl

It's picking up the version as 0.0.0. In contrast, on main:

Successfully built pymc-5.15.1+52.gc2c46a764.tar.gz and pymc-5.15.1+52.gc2c46a764-py3-none-any.whl

@maresb maresb marked this pull request as draft June 22, 2024 22:03
@Armavica
Copy link
Member Author

Armavica commented Jul 10, 2024

@maresb You are right, it looks like versioneer is not ready yet to deal with builds configured from pyproject.toml. I moved the settings of mypy and versioneer to pyproject.toml but kept the build in setup.py, I think this is the most that we can do for now. I think it builds fine now.

@Armavica Armavica changed the title Move tools and build system to pyproject.toml Move mypy and versioneer settings to pyproject.toml Jul 10, 2024
@Armavica Armavica force-pushed the pyproject branch 4 times, most recently from e10e16c to 1fd6a86 Compare July 10, 2024 05:10
@Armavica Armavica marked this pull request as ready for review July 10, 2024 10:28
Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carefully compared the build artifacts before and after, and this looks good to go!

@maresb
Copy link
Contributor

maresb commented Jul 10, 2024

It's great to get rid of versioneer.py, thanks @Armavica!!!

@Armavica Armavica added maintenance no releasenotes Skipped in automatic release notes generation labels Jul 11, 2024
@Armavica Armavica merged commit 641a60b into pymc-devs:main Jul 11, 2024
22 checks passed
@Armavica Armavica deleted the pyproject branch July 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants