-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-output support to GP Latent #7471
Conversation
looks good! not sure whats up with the unrelated test failures. Would it be possible to add @hchen19 as an author in the commit? Looks like its pretty easy here. |
@bwengals and @AlexAndorra , thanks for the suggestions and reviews of this PR. I think the test fails might come from the changes of |
> Co-authored-by: hchen19 <chenhaoyuan2018@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7471 +/- ##
==========================================
- Coverage 92.17% 92.16% -0.01%
==========================================
Files 103 103
Lines 17217 17220 +3
==========================================
+ Hits 15869 15871 +2
- Misses 1348 1349 +1
|
@AlexAndorra Just to let you know that it didn't work, you added a For comparison, a commit with several authors: Another way to proceed would have been to cherry-pick or rebase the original commits, which would have automatically added the dual attribution. |
Again, thanks for your work on this @hchen19! My fault for not merging your branch when you were finished. |
And of course I approved and merged it without refreshing the tab and seeing your comment @Armavica. Sorry guys that probably makes it a bit harder to fix. Is there any issue with ammending the commit? |
I commented one hour after you merged, so you couldn't have seen it :) Amending the commit would require to exceptionally lift the force-push protection of the main branch, since it's still the last commit I would say it's not too bad, but I don't know if it already has been done and we should probably ask someone else than me |
* Port 7226 and add dims support * Fix typo in HSGP prior method > Co-authored-by: hchen19 <chenhaoyuan2018@gmail.com> * Fix HSGP test
Porting over #7226 as it got staled a few months ago.
Ported the changes from @hchen19 and also added
dims
support togp.Latent.prior
. Ready for review 🍾Closes #7152
📚 Documentation preview 📚: https://pymc--7471.org.readthedocs.build/en/7471/