Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more distributions to be truncated #7476

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Aug 24, 2024

Description

AS reported in https://discourse.pymc.io/t/custom-distribution-for-truncated-gamma/11006/7?u=ricardov94 SymbolicRandomVariable distributions like ExGaussian couldn't be Truncated. The reason why this restriction was inplace are technical, and have to do with not all SymbolicRandomVariables being completely encapsulated in the inner graph. For distributions like Mixture this would be quite some work (which we may still want to do).

However many SymbolicRandomVariables are fine, specially those introduced in #7239.

This PR allow truncation of those that are fine.


📚 Documentation preview 📚: https://pymc--7476.org.readthedocs.build/en/7476/

@ricardoV94 ricardoV94 force-pushed the lift_truncated_restrictions branch from 4c0f4b7 to 7bdf2dc Compare August 27, 2024 08:22
@ricardoV94 ricardoV94 force-pushed the lift_truncated_restrictions branch from 7bdf2dc to ba61d12 Compare August 27, 2024 08:24
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (799c98f) to head (ba61d12).
Report is 100 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7476      +/-   ##
==========================================
- Coverage   92.17%   92.16%   -0.01%     
==========================================
  Files         103      103              
  Lines       17217    17214       -3     
==========================================
- Hits        15869    15866       -3     
  Misses       1348     1348              
Files with missing lines Coverage Δ
pymc/distributions/censored.py 100.00% <100.00%> (ø)
pymc/distributions/continuous.py 97.91% <100.00%> (ø)
pymc/distributions/truncated.py 99.45% <100.00%> (-0.01%) ⬇️
---- 🚨 Try these New Features:

@ricardoV94 ricardoV94 merged commit c92a9a9 into pymc-devs:main Aug 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants