Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set mode in check_start_vals #7482

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

lucianopaz
Copy link
Contributor

@lucianopaz lucianopaz commented Aug 28, 2024

Description

This just adds a some piping of keyword arguments from model.check_start_vals in order to be able to pass a mode to compile_pymc.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7482.org.readthedocs.build/en/7482/

@ricardoV94
Copy link
Member

I changed the label to maintenance to de-emphasize in the release notes. Feel free to revert if you disagree

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (c92a9a9) to head (5db847d).
Report is 97 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7482   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         103      103           
  Lines       17214    17214           
=======================================
  Hits        15866    15866           
  Misses       1348     1348           
Files with missing lines Coverage Δ
pymc/model/core.py 91.77% <100.00%> (ø)

@lucianopaz lucianopaz merged commit 064822a into pymc-devs:main Aug 28, 2024
22 checks passed
@lucianopaz lucianopaz deleted the start_val_mode branch August 28, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add a way to specify mode for check_start_vals
2 participants