Remove deprecated Distribution kwargs #7488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing these to reduce cognitive load for an eventual migration to a function-based distribution. These were deprecated in pymc-devs#5109, in 2021, as part of pymc 4 being released. We're on 5.x so these should be safe.
ricardoV94
approved these changes
Sep 3, 2024
ricardoV94
added
maintenance
major
|
One test is failing |
|
Thanks, missed that one, will add this afternoon. |
I keep the test, since it seems to cover behaviour not tested elsewhere.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7488 +/- ##
==========================================
+ Coverage 91.04% 92.16% +1.12%
==========================================
Files 103 103
Lines 17221 17200 -21
==========================================
+ Hits 15679 15853 +174
+ Misses 1542 1347 -195
|
|
Thanks @thomasaarholt |
mkusnetsov
pushed a commit
to mkusnetsov/pymc
that referenced
this pull request
Oct 26, 2024
* Remove deprecated Distribution kwargs Removing these to reduce cognitive load for an eventual migration to a function-based distribution. These were deprecated in pymc-devs#5109, in 2021, as part of pymc 4 being released. We're on 5.x so these should be safe. * Replace deprecated testval arg with initval in test I keep the test, since it seems to cover behaviour not tested elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing these to reduce cognitive load for an eventual migration to a function-based distribution.
These were deprecated in #4500 and #5109, in 2021, as part of pymc 4 being released. We're on 5.x so these should be safe to remove now.
I found about six more deprecated instances of code that were deprecated before the 5.0 release. I don't want to overload maintainers with more work, so will only make a PR with those if it is desired.
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7488.org.readthedocs.build/en/7488/