Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize HSGP.prior dimension names and order #7562

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Nov 5, 2024

Closes #7561

and changes the order of the dims, see #7561 (comment)


📚 Documentation preview 📚: https://pymc--7562.org.readthedocs.build/en/7562/

@github-actions github-actions bot added GP Gaussian Process bug labels Nov 5, 2024
@juanitorduz juanitorduz self-assigned this Nov 5, 2024
@juanitorduz juanitorduz added enhancements and removed GP Gaussian Process labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (3057351) to head (af142c4).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7562   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         106      106           
  Lines       17669    17669           
=======================================
  Hits        16403    16403           
  Misses       1266     1266           
Files with missing lines Coverage Δ
pymc/gp/hsgp_approx.py 88.39% <100.00%> (ø)

Copy link
Contributor

@bwengals bwengals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@juanitorduz juanitorduz merged commit a507ea8 into pymc-devs:main Nov 6, 2024
23 checks passed
@juanitorduz juanitorduz deleted the harmonize_hsgp_dim_names branch November 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Coordinates are not passed correctly to HSGP components
3 participants